Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 2 | Implement a linked list in Python#108
Open
Nataliia74 wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Glasgow | 25-SDC-Nov | Nataliia Volkova | Sprint 2 | Implement a linked list in Python#108Nataliia74 wants to merge 1 commit intoCodeYourFuture:mainfrom
Nataliia74 wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
Nataliia74
added
the
Needs Review
cjyuan
reviewed
Feb 27, 2026
Comment on lines
+40
to
+43
| if self.head is None: | ||
| return | ||
| if self.tail is None: | ||
| return None |
There was a problem hiding this comment.
Can you simplify the code on lines 40-43?
| self.tail = node.previous | ||
| self.tail.next = None | ||
| node.previous = None | ||
| node.next = None |
There was a problem hiding this comment.
What was the value of node.next before line 53?
Comment on lines
+46
to
+52
| if node.previous is None: | ||
| self.head = None | ||
| self.tail = None | ||
| else: | ||
| self.tail = node.previous | ||
| self.tail.next = None | ||
| node.previous = None |
There was a problem hiding this comment.
We could also just call remove(node) -- less code to maintain.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Issue: Implement a linked list in Python 9